PARALLEL SAFE support for functions missing (RM #2089)

[dpage]

Issue migrated from Redmine: https://redmine.postgresql.org/issues/2089 Originally created by Dave Page at 2017-01-18 09:36:21 UTC.

Per: https://www.postgresql.org/message-id/CAE0KEwE1UNdM0z-aEyub1AFePQu%3D1iuebaxA2tQvOF4QEoC8_g%40mail.gmail.com

I'm reviewing some PostGIS functions in pgAdmin 4. When I click on the SQL tab, I notice that the "PARALLEL SAFE" qualifier doesn't show up. But when I do an "\sf" on one of these functions in psql, I see the syntax (but not the NOT LEAKPROOF). Is this a known issue? I looked through issues list, but didn't see anything similar. For now, is the psql output the most accurate?

SQL tab from pgAdmin 4:

CREATE OR REPLACE FUNCTION public.st_intersects( geom1 geometry, geom2 geometry) RETURNS boolean LANGUAGE 'sql' COST 100.0 IMMUTABLE NOT LEAKPROOF AS $function$ SELECT $1 OPERATOR(public.&&) $2 AND public._ST_Intersects($1,$2) $function$;

psql output:

mydb=# \sf st_intersects (geometry,geometry) CREATE OR REPLACE FUNCTION public.st_intersects(geom1 geometry, geom2 geometry) RETURNS boolean LANGUAGE sql IMMUTABLE PARALLEL SAFE AS $function$SELECT $1 OPERATOR(public.&&) $2 AND public._ST_Intersects($1,$2)$function$

[dpage]

Comment migrated from Redmine: https://redmine.postgresql.org/issues/2089#note-1 Originally created by Khushboo Vashi at 2017-01-20 04:27:26 UTC.

Redmine ticket header update:

Name	Old Value	New Value
Status changed	New	In Progress
Assigned To changed		Khushboo Vashi

[dpage]

Comment migrated from Redmine: https://redmine.postgresql.org/issues/2089#note-2 Originally created by Khushboo Vashi at 2017-02-03 12:01:57 UTC.

The patch submitted.

https://www.postgresql.org/message-id/CAFOhELdtSDCcHTs+LJukGH5E_xUYfm0JJLwpKrq+SfLqcWthKg@mail.gmail.com

[dpage]

Comment migrated from Redmine: https://redmine.postgresql.org/issues/2089#note-3 Originally created by Dave Page at 2017-02-06 16:40:48 UTC.

Redmine ticket header update:

Name	Old Value	New Value
Fixed Version changed	1.2	1.3

[dpage]

Comment migrated from Redmine: https://redmine.postgresql.org/issues/2089#note-4 Originally created by Khushboo Vashi at 2017-02-10 07:29:31 UTC.

The updated patch submitted.

https://www.postgresql.org/message-id/CAFOhELckCk%3DXnadYMwZ5hifg2qLQ5Q5AWbuLOgG3LRax_K-DrQ%40mail.gmail.com

[dpage]

Comment migrated from Redmine: https://redmine.postgresql.org/issues/2089#note-5 Originally created by Khushboo Vashi at 2017-02-24 06:50:52 UTC.

The patch submitted. https://www.postgresql.org/message-id/CAFOhELdg272qxWw-zWA_NvE8qBUSrWbv04LQkzZwmLYN1-nDRg%40mail.gmail.com

[dpage]

Comment migrated from Redmine: https://redmine.postgresql.org/issues/2089#note-6 Originally created by Khushboo Vashi at 2017-02-24 12:21:09 UTC.

Applied in changeset commit:0ba9b7db4367b519339b5ab4504b58623f912cfe.

Redmine ticket header update:

Name	Old Value	New Value
Status changed	In Progress	In Testing
Done Ratio changed	0	90

[dpage]

Comment migrated from Redmine: https://redmine.postgresql.org/issues/2089#note-7 Originally created by Fahar Abbas at 2017-03-04 06:07:36 UTC.

This issue is resolved in latest commit ID: commit 523cd6f34a21034c9f7ee2678da797cb5e1e2c38

Tested Platform: Windows 2012 server R2 64(Python 2.7.12) MAC 10.9(Python 3.5)

Redmine ticket header update:

Name	Old Value	New Value
Status changed	In Testing	Resolved

[dpage]

Comment migrated from Redmine: https://redmine.postgresql.org/issues/2089#note-8 Originally created by Fahar Abbas at 2018-01-09 05:30:34 UTC.

Redmine ticket header update:

Name	Old Value	New Value
Done Ratio changed	90	100

[dpage]

Issue closed on Redmine.