search

pgadmin-org / pgadmin4

pgAdmin is the most popular and feature rich Open Source administration and development platform for PostgreSQL, the most advanced Open Source database in the world.
https://www.pgadmin.org
Other
2.43k stars 638 forks source link

On-demand loading for the query tool (RM #2137) #947

Closed dpage closed 2 years ago

dpage commented 7 years ago

Issue migrated from Redmine: https://redmine.postgresql.org/issues/2137 Originally created by Dave Page at 2017-02-01 10:51:42 UTC.

The query tool should load results on-demand, as supported by Slickgrid.

The initial resultset returned from the server should include column definitions and the first 1000(? Maybe this should be a configurable) rows.

When Slickgrid requires more rows, they should be supplied in additional batches. The pgAdmin server should use a database server-side cursor to minimise the memory requirements.

dpage commented 7 years ago

Comment migrated from Redmine: https://redmine.postgresql.org/issues/2137#note-1 Originally created by Dave Page at 2017-02-01 10:52:31 UTC.

Redmine ticket header update:

Name Old Value New Value
Fixed Version changed 1.3
dpage commented 7 years ago

Comment migrated from Redmine: https://redmine.postgresql.org/issues/2137#note-2 Originally created by Dave Page at 2017-03-09 09:35:23 UTC.

Redmine ticket header update:

Name Old Value New Value
Fixed Version changed 1.3 1.4
dpage commented 7 years ago

Comment migrated from Redmine: https://redmine.postgresql.org/issues/2137#note-3 Originally created by Dave Page at 2017-04-05 11:40:54 UTC.

Redmine ticket header update:

Name Old Value New Value
Fixed Version changed 1.4 1.5
dpage commented 7 years ago

Comment migrated from Redmine: https://redmine.postgresql.org/issues/2137#note-4 Originally created by Harshal Dhumal at 2017-04-13 14:30:11 UTC.

Redmine ticket header update:

Name Old Value New Value
Status changed New In Progress
Assigned To changed Harshal Dhumal
dpage commented 7 years ago

Comment migrated from Redmine: https://redmine.postgresql.org/issues/2137#note-5 Originally created by Harshal Dhumal at 2017-04-28 04:01:05 UTC.

For now we've decided not to use server sit cursor due its limitation. Further details on below mail thread

https://www.postgresql.org/message-id/flat/CAFiP3vxaM9ixpmaM04JAkTT1ONwmnMPwUCbK%2BkzCN%2Br6F%2B7-ZA%40mail.gmail.com#CAFiP3vxaM9ixpmaM04JAkTT1ONwmnMPwUCbK+kzCN+r6F+7-ZA@mail.gmail.com

dpage commented 7 years ago

Comment migrated from Redmine: https://redmine.postgresql.org/issues/2137#note-6 Originally created by Harshal Dhumal at 2017-05-07 17:12:56 UTC.

initial implementation of on demand loading of result set

patch: https://www.postgresql.org/message-id/CAFiP3vzas6ez9u-snfCuXzb1eL6_aZwAfrb%2B561sq8V19PT4Eg%40mail.gmail.com

dpage commented 7 years ago

Comment migrated from Redmine: https://redmine.postgresql.org/issues/2137#note-7 Originally created by Harshal Dhumal at 2017-05-12 08:00:28 UTC.

Updated patch with following fixes

  1. Added row number.
  2. load renaming result set if user performs select all operation either on grid or column.
  3. Fixed Row selection issue and row past issue.
  4. Updated existing jasmine test cases.

https://www.postgresql.org/message-id/CAFiP3vxvFMHv%3DyEOXcbxi9YABtTwOk3Feci92YMA4_9Fcp-4mA%40mail.gmail.com

dpage commented 7 years ago

Comment migrated from Redmine: https://redmine.postgresql.org/issues/2137#note-8 Originally created by Harshal Dhumal at 2017-05-12 10:03:53 UTC.

patch needs rebase

dpage commented 7 years ago

Comment migrated from Redmine: https://redmine.postgresql.org/issues/2137#note-9 Originally created by Harshal Dhumal at 2017-05-12 12:33:05 UTC.

Rebased patch.

https://www.postgresql.org/message-id/CAFiP3vzj2HBjau%2BN5TN%2BAsb_7DW6zgmPrzJf0rmd_H0NJ3Sttg%40mail.gmail.com

dpage commented 7 years ago

Comment migrated from Redmine: https://redmine.postgresql.org/issues/2137#note-10 Originally created by Dave Page at 2017-05-16 14:50:49 UTC.

Redmine ticket header update:

Name Old Value New Value
Fixed Version changed 1.5 1.6
dpage commented 7 years ago

Comment migrated from Redmine: https://redmine.postgresql.org/issues/2137#note-11 Originally created by Harshal Dhumal at 2017-06-27 13:03:11 UTC.

Applied in changeset commit:c65158312d6db6425abfde67d4f228910af223c3.

Redmine ticket header update:

Name Old Value New Value
Status changed In Progress In Testing
Done Ratio changed 0 90
dpage commented 7 years ago

Comment migrated from Redmine: https://redmine.postgresql.org/issues/2137#note-12 Originally created by Fahar Abbas at 2017-07-13 12:52:31 UTC.

This is resolved in community Build.

Redmine ticket header update:

Name Old Value New Value
Status changed In Testing Resolved
dpage commented 6 years ago

Comment migrated from Redmine: https://redmine.postgresql.org/issues/2137#note-13 Originally created by Fahar Abbas at 2018-01-09 05:37:52 UTC.

Redmine ticket header update:

Name Old Value New Value
Done Ratio changed 90 100
dpage commented 2 years ago

Issue closed on Redmine.