pgadmin-org / pgadmin4

pgAdmin is the most popular and feature rich Open Source administration and development platform for PostgreSQL, the most advanced Open Source database in the world.
https://www.pgadmin.org
Other
2.53k stars 656 forks source link

Move language selection to Preferences (RM #2190) #992

Closed dpage closed 2 years ago

dpage commented 7 years ago

Issue migrated from Redmine: https://redmine.postgresql.org/issues/2190 Originally created by Dave Page at 2017-02-17 13:07:31 UTC.

At present, UI language selection is automatic, based on the browsers accept-languages config. This doesn't seem to work so well - there's no way to configure it in the runtime, and there seems to be a disconnect between the language identifier strings used by Babel and browsers like Chrome in some cases. On Fedora 25 in English, we seem to automatically choose Chinese in the runtime!

Move the language selection into the Preferences as it was in pgAdmin III, to allow users to explicitly select the language they want. A combo box of options should be populated from the language array in config.py to allow the user to choose a language. We need to ensure we gracefully handle cases where a language is removed from the system, that the user may have previously selected.

dpage commented 7 years ago

Comment migrated from Redmine: https://redmine.postgresql.org/issues/2190#note-1 Originally created by Dave Page at 2017-02-20 09:42:39 UTC.

Redmine ticket header update:

Name Old Value New Value
Relationship (relates) changed RM #1963
dpage commented 7 years ago

Comment migrated from Redmine: https://redmine.postgresql.org/issues/2190#note-2 Originally created by Khushboo Vashi at 2017-02-24 09:46:05 UTC.

Redmine ticket header update:

Name Old Value New Value
Status changed New In Progress
Assigned To changed Khushboo Vashi
dpage commented 7 years ago

Comment migrated from Redmine: https://redmine.postgresql.org/issues/2190#note-3 Originally created by Dave Page at 2017-03-09 09:35:24 UTC.

Redmine ticket header update:

Name Old Value New Value
Fixed Version changed 1.3 1.4
dpage commented 7 years ago

Comment migrated from Redmine: https://redmine.postgresql.org/issues/2190#note-4 Originally created by Khushboo Vashi at 2017-03-10 13:57:08 UTC.

The patch submitted.

https://www.postgresql.org/message-id/CAFOhELd7-VHAJS74BJkn-EfSiS1huD==YBCUF+AeVqZ+JHmHDA@mail.gmail.com

dpage commented 7 years ago

Comment migrated from Redmine: https://redmine.postgresql.org/issues/2190#note-5 Originally created by Khushboo Vashi at 2017-03-17 10:27:08 UTC.

The updated patch submitted. https://www.postgresql.org/message-id/CAFOhELd_-%2B_gK2jpK0FtMoU80AfsNbo8g7jAm0_T2Hn1vv8%3Dmw%40mail.gmail.com

dpage commented 7 years ago

Comment migrated from Redmine: https://redmine.postgresql.org/issues/2190#note-6 Originally created by Khushboo Vashi at 2017-03-17 12:19:21 UTC.

The updated patch submitted.

https://www.postgresql.org/message-id/CAFOhELdy%2B14ZnS66EP2QQjUAe7i%2B-TNJDp-tr5Lp8EJeqbPXVA%40mail.gmail.com

dpage commented 7 years ago

Comment migrated from Redmine: https://redmine.postgresql.org/issues/2190#note-7 Originally created by Khushboo Vashi at 2017-03-24 09:44:25 UTC.

The patch updated.

https://www.postgresql.org/message-id/CAFOhELednsERbfOo7c3Smbdfs%2BmQrx9xm_P4mi9CwNWnxCYbGw%40mail.gmail.com

dpage commented 7 years ago

Comment migrated from Redmine: https://redmine.postgresql.org/issues/2190#note-8 Originally created by Khushboo Vashi at 2017-03-24 14:20:15 UTC.

Applied in changeset commit:0eda6033dfe88f9c7cb8f4aeccaa952ba2164d6c.

Redmine ticket header update:

Name Old Value New Value
Status changed In Progress In Testing
Done Ratio changed 0 90
dpage commented 7 years ago

Comment migrated from Redmine: https://redmine.postgresql.org/issues/2190#note-9 Originally created by Fahar Abbas at 2017-04-03 06:47:21 UTC.

Now simplified Chinese, Polish and English option added under Preferences and through login option.

Testing is in progress and will log issues with separate RMs.

This issue is resolved in latest commit ID:

Commit ID: commit bb0bd8acc5d6899ed514159e344928e6453faa63

Tested Platform: Ubuntu 16.04(Python 3.5) Windows 2012 R2 64(python 2.7.13)

Redmine ticket header update:

Name Old Value New Value
Status changed In Testing Resolved
dpage commented 6 years ago

Comment migrated from Redmine: https://redmine.postgresql.org/issues/2190#note-10 Originally created by Fahar Abbas at 2018-01-09 05:32:40 UTC.

Redmine ticket header update:

Name Old Value New Value
Done Ratio changed 90 100
dpage commented 2 years ago

Issue closed on Redmine.