search

pgajdos / fontinfo

Overview of Installed Fonts
GNU General Public License v2.0
6 stars 2 forks source link

Security issue and request to move https://fontinfo.opensuse.org/ to new openSUSE theme #3

Open lrupp opened 2 years ago

lrupp commented 2 years ago

The current public page at https://fontinfo.opensuse.org/ is still using the initial openSUSE theme, deployed ~10 years ago.

Meanwhile, there is not only a new theme, but also a security bug in one of the referenced JavaScript files.

So I have two questions:

  1. Can you please check, if the referenced jquery.js is really needed for the current https://fontinfo.opensuse.org/ ? - Or if it can be removed?
  2. Wouldn't it make sense to upgrade the page to the new theme as well, to have it unified across all openSUSE pages?
pgajdos commented 2 years ago

@lrupp yes, I could consider to spend hackweek on that.

pgajdos commented 2 years ago

2c52b6291a65dee6c3210fac83e83f977e4a34d1 plus a segfault and few failed asserts fixed now.

pgajdos commented 2 years ago

Now: can someone have a hint for me how to utilize jekyll theme instead of bento one?

pgajdos commented 2 years ago

https://hackweek.opensuse.org/21/projects/fontinfo-dot-opensuse-dot-org

cboltz commented 2 years ago

From a quick look, I have the impression that you generate the page from C code, so jekyll probably doesn't make too much sense. Also, jekyll is a static site generator, the theme we use is called chameleon ;-)

So - you are probably looking for the chameleon theme ;-)

You can find it on https://github.com/openSUSE/chameleon and some usage examples on https://static.opensuse.org/chameleon-3.0/ https://static.opensuse.org/chameleon-3.0/components.html and https://static.opensuse.org/chameleon-3.0/elements.html

If yo have questions, @hellcp can probably help you.

hellcp commented 2 years ago

I was actually considering using jekyll with fontinfo by making a theme that generated yaml files instead of html, so that I could minimize the amount of templating that was done in C and move it onto an actual templating engine. I didn't get very far with that though ;)

pgajdos commented 2 years ago

Thanks for tips, I will try something and let's see.

hellcp commented 2 years ago

Feel free to ask, some stuff we do in the themes may appear a bit cryptic, but it has some purpose more often than not. I can probably also help a bit with general page layout so it flows better, but that may be a bit out of scope :P

pgajdos commented 2 years ago

I think I have finished work on utilizing chameleon theme. New content will be published soon. jekyll is still not used, I think it will take lot of time I do not have right now. Thanks to @lrupp for patient explaining.

Feel free to ask, some stuff we do in the themes may appear a bit cryptic, but it has some purpose more often than not. I can probably also help a bit with general page layout so it flows better, but that may be a bit out of scope :P

@hellcp, thanks, please look at new fontinfo as soon as it is there and propose changes here. Thanks!