Proposal

[pgalonza]

Good afternoon, dear @zdm65477730 and @glitched-nx. I want to invite you to work together on the atmosphere fork. I think this will be a good practice.

[borntohonk]

Here's a suggestion of what to do instead of what you've done already.

:) fork.patch

[pgalonza]

borntohonk

Thank you, patch was applied on "feature-integration" branch

[borntohonk]

borntohonk

Thank you, patch was applied on "feature-integration" branch

It needs an alteration in https://github.com/Atmosphere-NX/Atmosphere/blob/master/stratosphere/loader/source/ldr_meta.cpp

haven't compiled it after rebase, and i notice now there's dependencies

        Result ValidateAcidSignature(Meta *meta, PlatformId platform, bool unk_unused) {
            /* Loader did not check signatures prior to 10.0.0. */
            {
                meta->check_verification_data = false;
                R_SUCCEED();
            }

that's the only change i'd make with latest atmosphere master in that file (without the full codeblock platformID platform is not set, which causes problems)

at least this is the cleanest one can get for rebasing origin master (atmosphere-nx/atmosphere master) while also retaining the ability to compile it. Removing anything else just causes for more to be required to be tracked.

[pgalonza]

@borntohonk

You can check the build in actions https://github.com/pgalonza/ns-Atmosphere/actions . All ValidateAcidSignature calls have been commented out https://github.com/search?q=repo%3Apgalonza%2Fns-Atmosphere%20ValidateAcidSignature&type=code

I have just started studying and would appreciate any advice. You can do a PR to make the desired changes.

[borntohonk]

@borntohonk

You can check the build in actions https://github.com/pgalonza/ns-Atmosphere/actions . All ValidateAcidSignature calls have been commented out https://github.com/search?q=repo%3Apgalonza%2Fns-Atmosphere%20ValidateAcidSignature&type=code

I have just started studying and would appreciate any advice. You can do a PR to make the desired changes.

If you check the entire fork.patch (all of the .diff) you'll see it contains code for embedding exefs .ips patches.

[borntohonk]

master.patch

this one applies to https://github.com/Atmosphere-NX/Atmosphere and compiles just fine, and will load ES, NIFM (network override), NIM (prodinfo crashfix), FS patches (and disable/override loader to a functional state by passing R_SUCCEED();

[pgalonza]

@borntohonk You can check the build in actions https://github.com/pgalonza/ns-Atmosphere/actions . All ValidateAcidSignature calls have been commented out https://github.com/search?q=repo%3Apgalonza%2Fns-Atmosphere%20ValidateAcidSignature&type=code I have just started studying and would appreciate any advice. You can do a PR to make the desired changes.

If you check the entire fork.patch (all of the .diff) you'll see it contains code for embedding exefs .ips patches.

Like this https://github.com/pgalonza/ns-Atmosphere/commit/5d2de8ec9333ac05452b9c81d58b2c8b13bb248e ?

[borntohonk]

@borntohonk You can check the build in actions https://github.com/pgalonza/ns-Atmosphere/actions . All ValidateAcidSignature calls have been commented out https://github.com/search?q=repo%3Apgalonza%2Fns-Atmosphere%20ValidateAcidSignature&type=code I have just started studying and would appreciate any advice. You can do a PR to make the desired changes.

If you check the entire fork.patch (all of the .diff) you'll see it contains code for embedding exefs .ips patches.

Like this 5d2de8e ?

https://git-scm.com/docs/git-apply

[borntohonk]

how to reproduce: git clone --recurse-submodules https://github.com/Atmosphere-NX/Atmosphere.git cd Atmosphere git branch New-branch git apply path/to/master.patch git add . git commit -m"Patch added" git remote add upstream https://github.com/pgalonza/ns-Atmosphere.git git fetch upstream

git push -f upstream

[pgalonza]

@borntohonk Ok, it`s for master of atmosphere project.

[pgalonza]

@borntohonk I'll come back to this after my vacation

[borntohonk]

@borntohonk I'll come back to this after my vacation

i saw you reference me in a commit, but you've just restored atmosphere acid check and not removed the if condition.

do as above and apply patch to atmosphere master repository to undo your bloat/uncessary changes and get a clean slate to proper working enviroment.

FS (assuming one boots with fusee and hekate method)/ES/NIFM(lan/wlan force enable)/NIM(prodinfo fix) and acid (loader) disabled with one simple line change, dns-mitm behavior changed

18_1_0.patch

[pgalonza]

@borntohonk I hope I managed to take into account all the points in feature-integration branch.

Thank you for guiding me.