search

pgamerx / yt-dislikes-viewer

A browser extension that allows you to see dislikes on a youtube video after the youtube update
https://yt-dislikes-viewer.js.org
GNU General Public License v3.0
296 stars 20 forks source link

Like/dislike bar is very tall #29

Closed dben89x closed 2 years ago

dben89x commented 2 years ago

The like/dislike bar stacks 6 of the following elements on top of each other, so that the bar comes out very tall:

<div class="progress" id="test" style="position: relative; height: 3px; width: 40%; background: rgb(205, 205, 205);"><div class="color" id="color" style="position: absolute; background: rgb(6, 95, 212); width: 97.9588%; height: 3px;"></div></div>

Screen Shot 2021-11-22 at 3 06 48 PM

Is this intended? When I manually remove 5 of the 6 elements, it seems to look right.

Below is a screenshot of the 6 stacked elements:

Screen Shot 2021-11-22 at 3 01 02 PM

And below is after removing 5 of the 6 elements:

Screen Shot 2021-11-22 at 3 07 13 PM

thereaper90917 commented 2 years ago

are you using the latest release here? that is a known bug from a previous release that got fixed :D

pgamerx commented 2 years ago

If I remember correctly, this was fixed in 1.6.6, but nonetheless I will check it.

thereaper90917 commented 2 years ago

If I remember correctly, this was fixed in 1.6.6, but nonetheless I will check it.

not sure the id in the screenshot is "test" we changed that to "custom-progress" when we did the fix for the ratio bar repeating itself. iirc

dben89x commented 2 years ago

If I remember correctly, this was fixed in 1.6.6, but nonetheless I will check it.

This is bizarre. I have 1.6.6 installed on 3 devices.

All devices are running Brave Version 1.32.106 Chromium: 96.0.4664.45 (Official Build) (x86_64)

On two of the three devices, the bar is short. On one of the devices, it's tall. The one device where it's tall is on a MacBook Air. The other two devices (MacBook Pro 15" and Mac Mini with a widescreen monitor) are fine.

I've double checked to make 100% sure that all devices are running the same version of Chromium and the same version of this repo.

Is there anything I should test? I've tried different resolutions in the web inspector on all 3 devices, but nothing changes.

Edit: I'm actually seeing 3 elements stacked now on the MacBook Pro 15". It was just one bar when visiting youtube directly after installing the add-on. Tried a hard refresh, not sure what else I can try.

Adib-C commented 2 years ago

I can confirm that the bar is very tall on the 1.6.6 version

Adib-C commented 2 years ago

I think there is some conflict with PR #26 and #30 which caused this problem

pgamerx commented 2 years ago

If I remember correctly, this was fixed in 1.6.6, but nonetheless I will check it.

This is bizarre. I have 1.6.6 installed on 3 devices.

All devices are running Brave Version 1.32.106 Chromium: 96.0.4664.45 (Official Build) (x86_64)

On two of the three devices, the bar is short. On one of the devices, it's tall. The one device where it's tall is on a MacBook Air. The other two devices (MacBook Pro 15" and Mac Mini with a widescreen monitor) are fine.

I've double checked to make 100% sure that all devices are running the same version of Chromium and the same version of this repo.

Is there anything I should test? I've tried different resolutions in the web inspector on all 3 devices, but nothing changes.

Edit: I'm actually seeing 3 elements stacked now on the MacBook Pro 15". It was just one bar when visiting youtube directly after installing the add-on. Tried a hard refresh, not sure what else I can try.

Today I will release v1.6.7, sorry for the issue and this shall be fixed in today's release (chromium only)

hisRoyalty commented 2 years ago

Is this issue fixed? If it is, it should be closed.

pgamerx commented 2 years ago

@dben89x it has been fixed in 1.7.5 aka latest release, sorry for the issue.