Closed louisgv closed 2 years ago
Thank you so much! I will review it once I get on my laptop
I have reviewed this, seems pretty good to me. But I have exams so I cannot do all the steps right now.
My exams end on 16th March,2022, I will merge this then. Thanks!
Best of luck to your exam :D
On Sun, Feb 27, 2022, 4:42 AM PGamerX @.***> wrote:
I have reviewed this, seems pretty good to me. But I have exams so I cannot do all the steps right now.
My exams end on 16th March,2022, I will merge this then. Thanks!
— Reply to this email directly, view it on GitHub https://github.com/pgamerx/yt-dislikes-viewer/pull/52#issuecomment-1053432983, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABTJP5T4V5SFIDCQHWLZ4KDU5HW2BANCNFSM5POFCCJQ . You are receiving this because you authored the thread.Message ID: @.***>
Thanks
I finally have time to review this!
Awesome! How was your final exams? :D
They were good, and they weren't my finals lol
Hi @pgamerx,
Love this extension! I was looking for ways to contribute, and thought adding a bit more ci might help. This PR introduces a new github action workflow that uses download-release-asset to download the latest release assets, and bpp to automatically submit the zip files to various extension stores. The action is set to run manually from the github action tab, but we can tweak it to run as frequent as needed! The only thing you would need to create is a
SUBMIT_KEYS
github repository secret.This secret is a json, with the schema defined here.
Here's a sample key for you:
You can find instructions on how to get the keys in the schema, or in this doc. If you use vscode, the schema should provide hint/intelisense when hovering over the json properties. If you need any help in setting up the keys, feel free to @ me! Otherwise if this doesn't seem necessary, feel free to close the PR :)
Side notes: bpp is an open source action, together with its dependencies. You can audit the source as well as providing any issue/feedback here: