search

pganalyze / pg_query_go

Go library to parse and normalize SQL queries using the PostgreSQL query parser
BSD 3-Clause "New" or "Revised" License
667 stars 79 forks source link

Add native spinlock support on RISC-V #62

Closed r-value closed 2 years ago

r-value commented 2 years ago

Patch from https://www.postgresql.org/message-id/dea97b6d-f55f-1f6d-9109-504aa7dfa421@gentoo.org

Hello,

The attached patch adds native spinlock support to PostgreSQL on RISC-V systems. As suspected by Richard W.M. Jones of Red Hat back in 2016, the __sync_lock_test_and_set() approach applied on arm and arm64 works here as well.

Tested against PostgreSQL 13.3 on a physical rv64gc system (BeagleV Starlight beta board) - builds and installs fine, all tests pass. From what I can see in gcc documentation this should in theory work on rv32 (and possibly rv128) as well, therefore the patch as it stands covers all RISC-V systems (i.e. doesn't check the value of __risc_xlen) - but I haven't confirmed this experimentally.

lfittl commented 2 years ago

@r-value Thanks for the contribution!

This is included via the upstream update in #64 (here, in the slightly modified form that was committed upstream), so I'll close this PR since we'll merge the other one shortly that supersedes this.