When preparing a talk about this app, I realized that the definition in chords.yaml for the Gray chord is not right. I have it as A4, C#4, E4, but that first one is supposed to be A3, so instead of playing A major, it's playing A/C (A major rooted in C). I don't think it's a huge deal here, because it's just one of the extended chords, but I'd like to remedy it — only problem is, I imagine it will be confusing for anyone who has already been training on the app.
My proposal:
Switch Gray to the right A3, C#4, E4 value
Add an option to swap the base and first inversion in the per-user settings
If that option is not present but the user has a history that includes completed runs at a level above gray, have the option default to "on"
Won't work perfectly, since user settings don't sync across devices and people may be using this across different devices, but it feels like the most simple backwards-compatible option. Maybe pop up a small warning the first time the opt-in happens, too?
We'll probably want to take this into account with #23 as well.
When preparing a talk about this app, I realized that the definition in
chords.yamlfor the Gray chord is not right. I have it asA4, C#4, E4, but that first one is supposed to beA3, so instead of playing A major, it's playing A/C (A major rooted in C). I don't think it's a huge deal here, because it's just one of the extended chords, but I'd like to remedy it — only problem is, I imagine it will be confusing for anyone who has already been training on the app.My proposal:
Won't work perfectly, since user settings don't sync across devices and people may be using this across different devices, but it feels like the most simple backwards-compatible option. Maybe pop up a small warning the first time the opt-in happens, too?
We'll probably want to take this into account with #23 as well.