search

pganssle / zoneinfo

Reference implementation for the proposed standard library module zoneinfo
Other
51 stars 20 forks source link

Fix Github Actions and pre-commit #127

Closed pganssle closed 1 year ago

pganssle commented 1 year ago

For some reason pylint was broken on my installation, so I had to bump the version.

GHA requires pinning to an older version of Ubuntu in order to run tests on Python 3.6.

andersk commented 1 year ago

GitHub dropped Python 3.6 from windows2022 and macos-11 as well; you’d need to go back to windows2019 and macos-10.15 for that.

(I doubt 3.6 support is worthwhile anymore—who is going to be upgrading backports.zoneinfo if they’re still on Python 3.6?—but your call.)

andersk commented 1 year ago

.github/workflows/build-publish.yml is going to need similar changes.

hugovk commented 1 year ago

Please see https://github.com/pganssle/zoneinfo/pull/128 to update this PR. It doesn't fix everything but moves things in the right direction.

pganssle commented 1 year ago

OK, this version is fully working, but it's kind of a big monolith, and I'd like to be able to individually link to PRs that fixed some of the user facing-ish changes in the changelog, so I'm going to break it up into smaller PRs that won't pass CI until the end, I think.