pgaref / HTTP_Request_Randomizer

Proxying Python Requests

http://pgaref.com/blog/python-proxy/

MIT License

151 stars 59 forks source link

Added some error handling #25

Closed gabrielgradinaru closed 7 years ago

gabrielgradinaru commented 7 years ago

4

-Added timeout when making request http connection -Added try/except in case a proxy parser fails

gabrielgradinaru commented 7 years ago

Hi,

I have added the configurable timeout on the UrlParser base class
For the try/except I have added ReadTimeout exception for now but there could also be other exceptions in the future and will have to be added
I think the best approach for Class TestProxyProviders is to mock the requests response because, you've said yourself that proxy websites are not reliable

coveralls commented 7 years ago

Coverage increased (+3.5%) to 44.785% when pulling f2decd79fb4cbc30f9a829aff22c77fb535be3c3 on gabrielgradinaru:master into 5621d8a6020090213b1828e0509c23f915e6eee0 on pgaref:master.

coveralls commented 7 years ago

Coverage increased (+3.5%) to 44.785% when pulling f2decd79fb4cbc30f9a829aff22c77fb535be3c3 on gabrielgradinaru:master into 5621d8a6020090213b1828e0509c23f915e6eee0 on pgaref:master.

pgaref commented 7 years ago

@gabrielgradinaru great job! Thanks for contributing :)