search

pgaref / HTTP_Request_Randomizer

Proxying Python Requests
http://pgaref.com/blog/python-proxy/
MIT License
148 stars 60 forks source link

Wrong author #38

Closed ieguiguren closed 6 years ago

ieguiguren commented 6 years ago

Hi

Samair.ru and rebro.weebly.com parsers were developed by me. Even if you separete it by modules (which I agree with), I'd should appear as author.

Commits: b585c5db3749c540d371b4286233725a3f41b7a8 @ieguiguren added samair.ru to web parsers 83cebd56ceac7af18440181a180ee4b39dfc0bfd @ieguiguren added samair parsing 70f1602552308bef1f0877b4be6f32aa0a8339fe @ieguiguren added http://rebro.weebly.com/proxy-list.html

pgaref commented 6 years ago

Hello @ieguiguren

I remember your contributions as you were one of the first project commiters :) As you mentioned the only reason the author name in the file is different is because I had to refactor the project at some point.

I would be more than happy to create a separate CONTRIBUTORS.md file to list the specific contibutions of each member (as they do in several open source projects) as tracking the original author of each specific code snippet is somewhat complicated. Would that make sense?

Cheers, Panagiotis

ieguiguren commented 6 years ago

Hey!!

Nice to hearing from you so soon. Yes, makes perfect sense. Thanks

Cheers, Ivan

On Fri, Oct 6, 2017 at 3:40 PM, Panagiotis Garefalakis < notifications@github.com> wrote:

Hello @ieguiguren https://github.com/ieguiguren

I remember your contributions as you were one of the first project commiters :) As you mentioned the only reason the author name in the file is different is because I had to refactor the project at some point.

I would be more than happy to create a separate CONTRIBUTORS file to list the specific contibutions of each member (as they do in several open source projects). Would that make sense?

Cheers, Panagiotis

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/pgaref/HTTP_Request_Randomizer/issues/38#issuecomment-334757885, or mute the thread https://github.com/notifications/unsubscribe-auth/ABudQa-5RZ3v1yur5XAE7LVvnctFGITbks5spi3TgaJpZM4Pwdaf .