search

pgaref / HTTP_Request_Randomizer

Proxying Python Requests
http://pgaref.com/blog/python-proxy/
MIT License
148 stars 60 forks source link

Allowing log_level to be set during instantiation of RequestProxy (#68) #67

Closed broglea closed 3 years ago

broglea commented 3 years ago

There is no current way to stop this from logging to the console with the way this was hard coded to log everything. You can't override the logging level of this module from a calling module because this overrides it whenever you instantiate a new instance of the class and things are logged during the __init__ of the object.

This allows the person using this library to pass in an optional log level.

broglea commented 3 years ago

@pgaref I added documentation of this to my branch. Should I also bump the version here in this PR so a new release can be cut with this change?

broglea commented 3 years ago

I am actually unsure how to properly bump version as in __init__.py it is 1.2.3 but latest release is 1.3.1

pgaref commented 3 years ago

I am actually unsure how to properly bump version as in __init__.py it is 1.2.3 but latest release is 1.3.1

Lets bump that to 1.3.2 and I can take care of the release.

Just make sure python -c 'import http_request_randomizer; print(http_request_randomizer.__version__)' prints the correct version

broglea commented 3 years ago

@pgaref done and done

pgaref commented 3 years ago

Merged to master, @broglea thanks again for the PR!

I am going to release this as 1.3.2 asap