pgaskin / NickelMenu

The easiest way to launch scripts, change settings, and run actions on Kobo e-readers.
https://pgaskin.net/NickelMenu
MIT License
591 stars 32 forks source link

Initial feedback #1

Closed jackiew1 closed 4 years ago

jackiew1 commented 4 years ago

@geek1011, Very nice. I'll use this new toy 😃 A few discussion points in no particular order:

NiLuJe commented 4 years ago

I would tend to agree with your assessment about a default config, if only one filled with commented out actual examples (something which, granted, the doc already does, but that fragment could easily be moved on its own to make it less daunting) ;).

(Do note that it does do something by default if no configs are found: it adds a NickelMenu entry that asks the user to read the doc).

The last point is a known issue:

https://github.com/geek1011/NickelMenu/blob/56af7743662263882cad2d70f762cdeb98ec1dfa/src/action_cc.cc#L111

jackiew1 commented 4 years ago

(Do note that it does do something by default: it adds a NickelMenu entry that asks the user to read the doc).

Yes, I did notice that but users seem to be more relaxed about editing an existing file than creating a new one from scratch 😃

The last point is a known issue:

Ah, OK, I hadn't realised that.

jackiew1 commented 4 years ago

Just an idea for another default option... I don't know if this kind of thing is possible but having a menu item to show a pop-up display of current battery level whilst inside a book may be useful.

I use MiniClock for this myself but most users probably don't. The little battery icon can be visually misleading if you're in NightMode.

NiLuJe commented 4 years ago

One potential quirk of shipping a default config inside the KoboRoot: it'll be wiped by a reinstall.

The other option is creating it programatically only if it doesn't already exist, which is more annoying to implement ;).