search

pgaskin / NickelMenu

The easiest way to launch scripts, change settings, and run actions on Kobo e-readers.
https://pgaskin.net/NickelMenu
MIT License
555 stars 28 forks source link

Issue highlighting on 4.31.19086 #119

Closed DavidNSB closed 2 years ago

DavidNSB commented 2 years ago

After installing the 4.31.19086 firmware, an attempt to hightlight a phrase, a popup "NickelMenu Could not find the required SelectionMenuView and SelectionMneuController symbols for adding selection menu items (this is a bug)" was displayed. After clicking OK 3 times, the highlight menu was displayed.

pgaskin commented 2 years ago

I will try and release a fix for this tonight.

shermp commented 2 years ago

@pgaskin do you want me to take a quick look at this once I've decompiled libnickel?

pgaskin commented 2 years ago

Yes, if you want to.

shermp commented 2 years ago

Ok, will do, just waiting for Ghidra to finish chugging away at this.

shermp commented 2 years ago

Looks like SelectionMenuController::lookupWeb() is gone.

Looks like it may have been replaced with SelectionMenuController::lookupGoogle() ~and SelectionMenuController::lookupBaidu()~

pgaskin commented 2 years ago

Fixed in v0.5.3.