pgaskin / NickelMenu

The easiest way to launch scripts, change settings, and run actions on Kobo e-readers.
https://pgaskin.net/NickelMenu
MIT License
512 stars 25 forks source link

Whitespace inconsistency in cmd_spawn/cmd_output is confusing #16

Closed shermp closed 4 years ago

shermp commented 4 years ago

In cmd_output and and cmd_spawn, the "timeout" and "quiet" fields respectively are whitespace sensitive. This is inconsistent with the rest of the config line, which ignores whitespace.

Perhaps this either needs to be better documented, or the actions should ignore whitespace for those fields, the same as what the config parser does.

I got bit with this myself when I was wondering why the following failed:

menu_item : main : Test Output : cmd_output : 1000 : echo Hello

(Note it fails saying there is no valid timeout)