Should the failsafe destroy thread be detached?

pgaskin / NickelMenu

The easiest way to launch scripts, change settings, and run actions on Kobo e-readers.

https://pgaskin.net/NickelMenu

MIT License

512 stars 25 forks source link

Closed NiLuJe closed 4 years ago

NiLuJe commented 4 years ago

AFAIK, the default state of a pthread is joined.

Not waiting for it means it "leaks" on termination.

Should we make it detached to take care of that, or am I missing some Qt quirk?

(I can take care of & test that, just wanted to double-check first ;)).

pgaskin commented 4 years ago

Yes, it seems I overlooked that earlier.

NiLuJe commented 4 years ago

Cool, I'll give it a go after dinner ;).