Closed NiLuJe closed 4 years ago
^ A note about branch deletion and squash/merge: I've settled on using squash commits and deleting branches for small changes which are tracked in a PR. For larger changes, I'll use rebasing unless a merge commit would be more suitable.
:+1:
(You'll notice I've been reusing a "disposable" topical branch named "misc" for trivial stuff. I'll keep meatier features in named branches on my end).
@geek1011: Complete sidebar: I'll be including NM in the KOReader/Plato OCP packages, unless you have an objection to that ;).
@NiLuJe: Sounds good. One question: how are you planning to deal with updates?
I try to rebuild those ASAP on any new Plato/KOReader release, and/or any significant KFMon changes (i.e., it's actually always picking up a KFMon git build).
So, I'll just add NM to the list of stuff that might require a rebuild ;).
EDIT: In practice, that means either using the latest release via the GitHub API, or using a local build like for KFMon.
OK.
EDIT: In practice, that means either using the latest release via the GitHub API, or using a local build like for KFMon.
Note that you can link directly to the latest release with https://github.com/geek1011/NickelMenu/releases/latest/download/KoboRoot.tgz.
Might come in handy one day, because I know quite a few people extremely averse to updating stuff ^^.
e.g.,