search

pgaskin / NickelMenu

The easiest way to launch scripts, change settings, and run actions on Kobo e-readers.
https://pgaskin.net/NickelMenu
MIT License
512 stars 25 forks source link

menu hopping #26

Closed ssd2 closed 4 years ago

ssd2 commented 4 years ago

One of my greatest irritations in latest firmwares is the removal of the "home" button from the reading screen. Sometimes I have to hit return two or three times to get back to home.

Would it be possible to add items from the home screen menu (like home, my books, my articles, settings) so they could be added to the reading overflow menu?

pgaskin commented 4 years ago

I'll look into that. My only concern with doing this is how it will interact with Nickel's reading session management, so I'll need to check how that works and if MainWindowController handles everything as needed.

pgaskin commented 4 years ago

OK, this will be doable (EventEngine::endReadingSession is called by ReadingController::viewWillDisappear, which is an implementation of AbstractController::viewWillDisappear, which is called when switching views using the nav mixins).

ssd2 commented 4 years ago

Ironically, you added everything except what I asked for -- a link to the home screen.

Not to be ungrateful, I think this change is actually wonderful, and although I'd still like to have HOME, with all these other options, I'm not sure I'd ever use it!! Thanks!

pgaskin commented 4 years ago

Oh, I guess I misinterpreted the question. I'll add a home option for the next version, although it'll be part of nickel_misc rather than nickel_open for technical reasons.