search

pgaskin / NickelMenu

The easiest way to launch scripts, change settings, and run actions on Kobo e-readers.
https://pgaskin.net/NickelMenu
MIT License
512 stars 25 forks source link

Implement menu item generators #28

Closed pgaskin closed 4 years ago

pgaskin commented 4 years ago

closes #4

pgaskin commented 4 years ago

I've tested this with the following entries:

generator:main:_test:0
generator:main:_test:
generator:main:_test:invalid
generator:main:_test:5

In addition, I've tested calling nm_config_generate twice, to ensure it is idempotent and the old item removal and freeing works fine, if we ever use it in the future.

pgaskin commented 4 years ago

@NiLuJe, @shermp, can you take a look at the code and test this (with your current config plus the config entries above) to ensure I didn't miss anything or create regressions?

NiLuJe commented 4 years ago

Looks good on my end, nothing broke ;).

generator:main:_test works, too (as well as it can given this particular generator ^^).

Going to try to implement #29 now... :).

NiLuJe commented 4 years ago

Gah. fat-fingered a bogus branch name, feel free to delete the kfmon-generator branch, I forgot the namespace.

NiLuJe commented 4 years ago

Looking good over on https://github.com/geek1011/NickelMenu/tree/niluje/kfmon-generator :).