search

pgaskin / NickelMenu

The easiest way to launch scripts, change settings, and run actions on Kobo e-readers.
https://pgaskin.net/NickelMenu
MIT License
512 stars 25 forks source link

Implement nickel_open action #38

Closed pgaskin closed 4 years ago

pgaskin commented 4 years ago

closes #26

pgaskin commented 4 years ago

I've tested this on 4.20.15015 with:

menu_item:main:test--discover_storefront:nickel_open:discover:storefront
menu_item:reader:test--discover_storefront:nickel_open:discover:storefront
menu_item:main:test--discover_wishlist:nickel_open:discover:wishlist
menu_item:reader:test--discover_wishlist:nickel_open:discover:wishlist
menu_item:main:test--library_library:nickel_open:library:library
menu_item:reader:test--library_library:nickel_open:library:library
menu_item:main:test--library_library2:nickel_open:library:library2
menu_item:reader:test--library_library2:nickel_open:library:library2
menu_item:main:test--library_all:nickel_open:library:all
menu_item:reader:test--library_all:nickel_open:library:all
menu_item:main:test--library_authors:nickel_open:library:authors
menu_item:reader:test--library_authors:nickel_open:library:authors
menu_item:main:test--library_series:nickel_open:library:series
menu_item:reader:test--library_series:nickel_open:library:series
menu_item:main:test--library_shelves:nickel_open:library:shelves
menu_item:reader:test--library_shelves:nickel_open:library:shelves
menu_item:main:test--library_pocket:nickel_open:library:pocket
menu_item:reader:test--library_pocket:nickel_open:library:pocket
menu_item:main:test--library_dropbox:nickel_open:library:dropbox
menu_item:reader:test--library_dropbox:nickel_open:library:dropbox
menu_item:main:test--reading_life_reading_life:nickel_open:reading_life:reading_life
menu_item:reader:test--reading_life_reading_life:nickel_open:reading_life:reading_life
menu_item:main:test--reading_life_stats:nickel_open:reading_life:stats
menu_item:reader:test--reading_life_stats:nickel_open:reading_life:stats
menu_item:main:test--reading_life_awards:nickel_open:reading_life:awards
menu_item:reader:test--reading_life_awards:nickel_open:reading_life:awards
menu_item:main:test--reading_life_words:nickel_open:reading_life:words
menu_item:reader:test--reading_life_words:nickel_open:reading_life:words
menu_item:main:test--store_overdrive:nickel_open:store:overdrive
menu_item:reader:test--store_overdrive:nickel_open:store:overdrive
menu_item:main:test--store_search:nickel_open:store:search
menu_item:reader:test--store_search:nickel_open:store:search
menu_item:main:test--1:nickel_open:
menu_item:reader:test--1:nickel_open:
menu_item:main:test--2:nickel_open:test
menu_item:reader:test--2:nickel_open:test
menu_item:main:test--3:nickel_open:test:test
menu_item:reader:test--3:nickel_open:test:test
menu_item:main:test--4:nickel_open:library:test
menu_item:reader:test--4:nickel_open:library:test
menu_item:main:test--5:nickel_open:library:
menu_item:reader:test--5:nickel_open:library:
NiLuJe commented 4 years ago

Will check it out later tonight, thanks ;).

NiLuJe commented 4 years ago

Working fine on my end (that library2 action is mighty fun (and state is persistent across reboots!). Nothing actually does it quite like that in the stock FW, right?) ;).

The obvious missing entry is a "Go back home", but after a look at the code and the symbols list, it kinda makes sense ;p.

Which still begs the question what the main menu's "Home" entry is doing (and/or the "Back to Home" in the reader)...

pgaskin commented 4 years ago

Which still begs the question what the main menu's "Home" entry is doing (and/or the "Back to Home" in the reader)...

That's actually pretty simple, but it doesn't involve the nav mixins. It's just MainWindowController::clear. I'd probably put it into nickel_misc though, as it fits better there.

jackiew1 commented 4 years ago

@geek1011 ,

Any plans to add that 'Back to Home' menu item? I'd definitely use it. Not that that's likely to influence you over much. 😁

pgaskin commented 4 years ago

@jackiew1: #39