NM crashes after a config reload when an item from the second menu opened after the reload is pressed

pgaskin / NickelMenu

The easiest way to launch scripts, change settings, and run actions on Kobo e-readers.

https://pgaskin.net/NickelMenu

MIT License

591 stars 32 forks source link

NM crashes after a config reload when an item from the second menu opened after the reload is pressed #57

Closed pgaskin closed 4 years ago

pgaskin commented 4 years ago

See https://github.com/geek1011/NickelMenu/issues/56#issuecomment-649887545.

This is a regression introduced by #47 (it isn't in any release yet).

pgaskin commented 4 years ago

To reproduce this issue:

Start with a config which has items in the main and reader menus.
Open the main menu.
Change the config (over telnet or USB).
Open a book and open the reader menu.
Go back to the home screen, open the main menu, and press any item on it.
Nickel will segfault.

This won't work the other way around since the reader menu will get regenerated from the current config every time a book is opened, but the main menu is persistent.