Improve extensibility by changing `nickel_setting` and splitting `nickel_extras:web_browser`

pgaskin / NickelMenu

The easiest way to launch scripts, change settings, and run actions on Kobo e-readers.

https://pgaskin.net/NickelMenu

MIT License

591 stars 32 forks source link

Improve extensibility by changing `nickel_setting` and splitting `nickel_extras:web_browser` #59

Closed pgaskin closed 4 years ago

pgaskin commented 4 years ago

https://github.com/geek1011/NickelMenu/commit/4f2e059bb5d135e50cecade0e345935f8adc2c69#commitcomment-40240140:

I'm also considering splitting nickel_extras:web_browser into a new action and rearranging the options for nickel_setting into nickel_setting:{enable,disable,toggle}:<setting>, as these changes would simplify the config (both parsing and documentation) significantly. It would also allow for more future extensibility, especially with non-boolean setting values.

pgaskin commented 4 years ago

https://github.com/geek1011/NickelMenu/commit/4f2e059bb5d135e50cecade0e345935f8adc2c69#commitcomment-40241220 (@jackiew1):

No strong opinions. I don't use web_browser. For nickel_setting, as long as I can enable/disable/toggle somehow, I don't much mind how it's achieved.

pgaskin commented 4 years ago

https://github.com/geek1011/NickelMenu/commit/4f2e059bb5d135e50cecade0e345935f8adc2c69#commitcomment-40242637 (@NiLuJe):

What @jackiew1 said ;).