pgaskin / NickelMenu

The easiest way to launch scripts, change settings, and run actions on Kobo e-readers.
https://pgaskin.net/NickelMenu
MIT License
591 stars 32 forks source link

Deprecate nickel_open:library:library in favor of nickel_open:library:library2 #81

Closed pgaskin closed 4 years ago

pgaskin commented 4 years ago

Since 4.23.15505, it isn't safe to use LibraryNavMixin::showLibrary directly anymore, and upon further investigation, it appears that it was never intended to be used directly to begin with and that it only worked by chance.

library, which uses LibraryNavMixin::showLibrary will be deprecated in favor of library2, which uses LibraryNavMixin::showLastLibraryTab. Since these are almost identical in behavior (the only difference is that showLibrary didn't set the library tab), I will be making library a synonym for library2 in v0.3.2, then completely removing library2 in v0.4.0.

See https://github.com/pgaskin/NickelMenu/issues/79#issuecomment-672278853.