search

pgaskin / NickelMenu

The easiest way to launch scripts, change settings, and run actions on Kobo e-readers.
https://pgaskin.net/NickelMenu
MIT License
591 stars 32 forks source link

Custom icon for NickelMenu main menu on 4.23.15505 #84

Closed pgaskin closed 3 years ago

pgaskin commented 4 years ago

See #78.

NiLuJe commented 4 years ago

Random thought: instead of/in the meantime, couldn't we simply re-purpose an existing one? (I was thinking of the Erlenmeyer of the "Beta" settings, or any of the existing gear/tool-like ones).

pgaskin commented 4 years ago

instead of/in the meantime, couldn't we simply re-purpose an existing one

I was actually just thinking something along the same line. I'm considering making an experimental option for now to change the path used for the QPixmap, as that would allow loading it from an arbitrary resource or a file. That allows us to sidestep the decisions for this change for now.

The only thing I'm concerned about is I don't want experimental options to become widely-used and having people complain about breakage/removal/changes later. That's a discussion for #87, though.

pgaskin commented 3 years ago

I've decided to go with an experimental option to change the QPixmap path for now. I'll need to test what happens if it doesn't exist or is invalid, though, to make sure it won't cause any problems.

acestronautical commented 2 years ago

I tried setting:

experimental:menu_main_15505_icon_active:/images/reading/beta_features_hit.png
experimental:menu_main_15505_icon:/images/reading/beta_features.png

but it doesn't seem to be working. Is this supposed to work with the native paths on kobo? (I have libra 2)

pgaskin commented 2 years ago

Try adding another colon before the path and see if it works.