cmd_output action not displaying newlines

pgaskin / NickelMenu

The easiest way to launch scripts, change settings, and run actions on Kobo e-readers.

https://pgaskin.net/NickelMenu

MIT License

507 stars 24 forks source link

cmd_output action not displaying newlines #92

Closed jackiew1 closed 3 years ago

jackiew1 commented 3 years ago

@pgaskin As per your suggestion I'm creating this issue (minor) for you to look at if/when you have the time and inclination.

Details at https://www.mobileread.com/forums/showpost.php?p=4042416&postcount=317 posts #317-324

pgaskin commented 3 years ago

This would be due to _ZN6QLabel13setTextFormatEN2Qt10TextFormatE being called for the ConfirmationDialog text with a value of 0x1 (Qt::RichText), which causes the text to be interpreted as HTML. I'm not sure if this was the behaviour in previous firmware versions.

This should be fixable by using Qt::convertFromPlainText with Qt::WhiteSpacePre.

cc @shermp for NickelDBus

Edit: I've checked this against 11655, so it appears that this has been the case since the beginning.

shermp commented 3 years ago

I kind of like the HTML formatted text. Makes it easy to do simple bold/italics, so I probably won't change it for NickelDBus, although maybe I need to note it in the documentation.