search

pgaskin / NickelMenu

The easiest way to launch scripts, change settings, and run actions on Kobo e-readers.
https://pgaskin.net/NickelMenu
MIT License
507 stars 24 forks source link

Fix cmd_output newlines not being displayed #95

Closed pgaskin closed 3 years ago

pgaskin commented 3 years ago

ConfirmationDialog uses Qt::RichText for the body text, which causes line breaks to be collapsed since the text is rendered as HTML. This can be fixed by using Qt::convertFromPlainText with Qt::WhiteSpacePre.

fixes #92

pgaskin commented 3 years ago

@jackiew1: https://nm.storage.geek1011.net/artifacts/commit/393b4508962d4e739d3a4079a8b4aa2d4c0134a4/KoboRoot.tgz

jackiew1 commented 3 years ago

@jackiew1: https://nm.storage.geek1011.net/artifacts/commit/393b4508962d4e739d3a4079a8b4aa2d4c0134a4/KoboRoot.tgz

I tested your update. The newlines seem to be fixed but it looks like some kind of unicode error ??? now exists. See pic. nm_newlines

pgaskin commented 3 years ago

That's been fixed in the latest commit:

https://nm.storage.geek1011.net/artifacts/commit/321e086ecb970b038c1e083322d965c075f58ff2/KoboRoot.tgz

jackiew1 commented 3 years ago

That's been fixed in the latest commit:

https://nm.storage.geek1011.net/artifacts/commit/321e086ecb970b038c1e083322d965c075f58ff2/KoboRoot.tgz

Yes, that works OK for me now. I only have one menu item which uses cmd_output so testing quite limited.