Closed pgaskin closed 2 years ago
@pgaskin
I'm planning to add the beta patch from #93, KePub stylesheet additions - optimizeLegibility
, to the libnickel yaml file for this release, so please don't release patches until I've been able to do it. I don't see 4.31.19086 in the versions
section yet, so can't do it at the moment.
Also it's midnight here so not much time for me to do any testing tonight. I will have time tomorrow, though.
Is there some reason why your firmware page doesn't have a link for the Mark9 fw for the Libra2?
I'm planning to add the beta patch from #93, KePub stylesheet additions - optimizeLegibility, to the libnickel yaml file for this release, so please don't release patches until I've been able to do it. I don't see 4.31.19086 in the versions section yet, so can't do it at the moment.
OK, I'll wait until tomorrow. It'll be in the versions section as soon as I take a quick look at libnickel and extract nickel's resources (probably within the next 30-60 minutes).
Is there some reason why your firmware page doesn't have a link for the Mark9 fw for the Libra2?
It doesn't appear to have been released for the Libra2 to any of the affiliates.
Resource extraction:
./qrc2zip --output "nickel.19086.qInitResources_resources.zip" --recursive --verbose "nickel" 1 $((0x12de920 - 0x0010000)) $((0x00271f0 - 0x0010000)) $((0x12de428 - 0x0010000)) || { echo "Error: qrc2zip failed." 1>&2; exit 1; }
./qrc2zip --output "nickel.19086.qInitResources_translations.zip" --recursive --verbose "nickel" 1 $((0x1675568 - 0x0010000)) $((0x12ded10 - 0x0010000)) $((0x16752e0 - 0x0010000)) || { echo "Error: qrc2zip failed." 1>&2; exit 1; }
./qrc2zip --output "nickel.19086.qInitResources_styles.zip" --recursive --verbose "nickel" 1 $((0x1695328 - 0x0010000)) $((0x1675680 - 0x0010000)) $((0x1692840 - 0x0010000)) || { echo "Error: qrc2zip failed." 1>&2; exit 1; }
./qrc2zip --output "nickel.19086.qInitResources_certificates.zip" --recursive --verbose "nickel" 1 $((0x16bc900 - 0x0010000)) $((0x1695f30 - 0x0010000)) $((0x16bb8b0 - 0x0010000)) || { echo "Error: qrc2zip failed." 1>&2; exit 1; }
https://krc.storage.pgaskin.net/nickel.19086.qInitResources_certificates.zip https://krc.storage.pgaskin.net/nickel.19086.qInitResources_resources.zip https://krc.storage.pgaskin.net/nickel.19086.qInitResources_styles.zip https://krc.storage.pgaskin.net/nickel.19086.qInitResources_translations.zip
Errors:
/home/patrick/src/kobopatch-patches/src/versions/4.31.19086/libadobe.so.yaml/pgaskin.yaml: Remove PDF map widget shown during panning: could not apply patch "Remove PDF map widget shown during panning": line 9: inst 4: ReplaceBytes: could not find specified bytes
/home/patrick/src/kobopatch-patches/src/versions/4.31.19086/libnickel.so.1.0.0.yaml/pgaskin.yaml: Both page turn sides go next: could not apply patch "Both page turn sides go next": line 17: inst 4: ReplaceBytes: could not find specified bytes
/home/patrick/src/kobopatch-patches/src/versions/4.31.19086/libnickel.so.1.0.0.yaml/pgaskin.yaml: Customize ComfortLight settings: could not apply patch "Customize ComfortLight settings": line 553: inst 4: ReplaceInt: could not find specified bytes at offset
/home/patrick/src/kobopatch-patches/src/versions/4.31.19086/libnickel.so.1.0.0.yaml/pgaskin.yaml: Replace adobe page numbers toggle with invert screen: could not apply patch "Replace adobe page numbers toggle with invert screen": line 44: inst 4: ReplaceBytes: could not find specified bytes
/home/patrick/src/kobopatch-patches/src/versions/4.31.19086/nickel.yaml/pgaskin.yaml: Increase size of kepub chapter progress chart: could not apply patch "Increase size of kepub chapter progress chart": line 28: inst 4: ReplaceZlib: not a zlib stream
/home/patrick/src/kobopatch-patches/src/versions/4.31.19086/nickel.yaml/pgaskin.yaml: Remove forgot pin button from lock screen: could not apply patch "Remove forgot pin button from lock screen": line 20: inst 4: ReplaceZlib: not a zlib stream
The usual, but also Both page turn sides go next
(this one will probably need new offsets) and Replace adobe page numbers toggle with invert screen
(this one might go).
@jackiew, I've pushed most of the patches.
I may need to rewrite Customize ComfortLight settings
.
@pgaskin, I've added the new patch KePub stylesheet additions - optimizeLegibility
(or more precisely reinstated it) with a caveat in the Description about possible side effects when highlighting vertical text.
From your Error report it doesn't look like any of my patches need changing so I'll leave it to you to decide when to do the release, with or without Customize ComfortLight settings
.
Thanks for taking the time to get this done tonight, @jackiew1.
I will most likely do the release tonight after I deal with the NickelMenu regression and backport your patch updates from November. I will also update the ComfortLight patch for the release too as long as the logic is mostly the same.
Customize ComfortLight settings
(@shermp)KePub stylesheet additions - optimizeLegibility
(@jackiew1)