search

pgaskin / kobopatch-patches

Patches for use with kobopatch.
https://pgaskin.net/kobopatch-patches/
MIT License
227 stars 22 forks source link

Create zmanji.yaml to contain Discover button remapping patch. #82

Closed zmanji closed 3 years ago

zmanji commented 3 years ago

This adds zmanji.yaml for libnickel. It contains a single patch proposed by me which I use and find useful.

This remaps the discover button on the bottom navbar to open up the Pocket article list instead of the Kobo store.

It doesn't have to be accepted but I am putting it up here to share with the maintains and other users of the repository.

jackiew1 commented 3 years ago

@zmanji

@pgaskin hasn't commented on this so I will. Doesn't existing libnickel.so.1.0.0.yaml patch Only show Pocket SmartLink already give 1-click access to Pocket?

I'm not trying to say you shouldn't use this patch (or any other patch you have the skills to create) on your own device, but why does the published kobopatch pack need both patches? Especially when this new one removes access to the Kobo store which could potentially open a whole new can of worms.

pgaskin commented 3 years ago

I agree with @jackiew1 on the second part. We generally avoid touching stuff to do with the store itself, or to do with OverDrive/Dropbox/etc. Sorry about that.

One patch request you might want to work on instead if you're interested is Reading progress indicator customization. This one is mainly about finding where it's drawn. Since you're newer to this, using a debugger or instrumenting Nickel with NickelHook or Frida might be useful.