Closed pgaskin closed 3 years ago
pgaskin
commented
3 years ago pgaskin
commented
3 years ago Patch test results:
Errors:
/home/patrick/src/kobopatch-patches/src/versions/4.26.16704/nickel.yaml/pgaskin.yaml: Remove forgot pin button from lock screen: could not apply patch "Remove forgot pin button from lock screen": line 20: inst 4: ReplaceZlib: not a zlib stream
/home/patrick/src/kobopatch-patches/src/versions/4.26.16704/libnickel.so.1.0.0.yaml/geoffr.yaml: Set font scale factor: could not apply patch "Set font scale factor": line 531: inst 3: ReplaceInt: could not find specified bytes at offset
/home/patrick/src/kobopatch-patches/src/versions/4.26.16704/libnickel.so.1.0.0.yaml/geoffr.yaml: Set KePub hyphenation: could not apply patch "Set KePub hyphenation": line 320: inst 3: ReplaceBytes: could not find specified bytes
/home/patrick/src/kobopatch-patches/src/versions/4.26.16704/libnickel.so.1.0.0.yaml/pgaskin.yaml: Customize ComfortLight settings: could not apply patch "Customize ComfortLight settings": line 566: inst 4: ReplaceInt: could not find specified bytes at offset
/home/patrick/src/kobopatch-patches/src/versions/4.26.16704/libnickel.so.1.0.0.yaml/pgaskin.yaml: Hide browser from beta features: could not apply patch "Hide browser from beta features": line 80: inst 3: ReplaceBytes: could not find specified bytes
/home/patrick/src/kobopatch-patches/src/versions/4.26.16704/libnickel.so.1.0.0.yaml/pgaskin.yaml: Allow rotation on all devices: could not apply patch "Allow rotation on all devices": line 432: inst 3: ReplaceBytes: could not find specified bytes
/home/patrick/src/kobopatch-patches/src/versions/4.26.16704/libnickel.so.1.0.0.yaml/pgaskin.yaml: DeveloperSettings - AutoUsbGadget: could not apply patch "DeveloperSettings - AutoUsbGadget": line 637: inst 3: ReplaceBytes: could not find specified bytes
/home/patrick/src/kobopatch-patches/src/versions/4.26.16704/nickel.yaml/oren64.yaml: New home screen subtitle custom font: could not apply patch "New home screen subtitle custom font": line 31: inst 4: ReplaceZlib: not a zlib streamThe same as usual.
pgaskin
commented
3 years ago Resource extraction:
echo "nickel@16704/qInitResources_resources"; ./qrc2zip --output "nickel.16704.qInitResources_resources.zip" --recursive --verbose "nickel" 1 $((0x11698e0 - 0x0010000)) $((0x0026818 - 0x0010000)) $((0x1169470 - 0x0010000)) || { echo "Error: qrc2zip failed." 1>&2; exit 1; }
echo "nickel@16704/qInitResources_translations"; ./qrc2zip --output "nickel.16704.qInitResources_translations.zip" --recursive --verbose "nickel" 1 $((0x14c7488 - 0x0010000)) $((0x1169c90 - 0x0010000)) $((0x14c7200 - 0x0010000)) || { echo "Error: qrc2zip failed." 1>&2; exit 1; }
echo "nickel@16704/qInitResources_styles"; ./qrc2zip --output "nickel.16704.qInitResources_styles.zip" --recursive --verbose "nickel" 1 $((0x14e4218 - 0x0010000)) $((0x14c75a0 - 0x0010000)) $((0x14e1b98 - 0x0010000)) || { echo "Error: qrc2zip failed." 1>&2; exit 1; }
echo "nickel@16704/qInitResources_certificates"; ./qrc2zip --output "nickel.16704.qInitResources_certificates.zip" --recursive --verbose "nickel" 1 $((0x150b5a0 - 0x0010000)) $((0x14e4d00 - 0x0010000)) $((0x150a550 - 0x0010000)) || { echo "Error: qrc2zip failed." 1>&2; exit 1; }https://krc.storage.pgaskin.net/nickel.16704.qInitResources_certificates.zip https://krc.storage.pgaskin.net/nickel.16704.qInitResources_resources.zip https://krc.storage.pgaskin.net/nickel.16704.qInitResources_styles.zip https://krc.storage.pgaskin.net/nickel.16704.qInitResources_translations.zip
pgaskin
commented
3 years ago 
jackiew1
commented
3 years ago @pgaskin There are only 6 changed nickel .qss resources. Only the first one has an existing patch in nickel.yaml but I don't think it needs any changes.
Show all games)There are no added or removed .qss resources.
At first glance a bit of a non-event for my workload. 😄
pgaskin
commented
3 years ago Random notes:
bol.com, but I haven't looked into it in detail yet.pgaskin
commented
3 years ago Thanks, @jackiew1. I'll make a release sometime today after I get a chance to test the patches.
jackiew1
commented
3 years ago /home/patrick/src/kobopatch-patches/src/versions/4.26.16704/nickel.yaml/oren64.yaml: New home screen subtitle custom font: could not apply patch "New home screen subtitle custom font": line 31: inst 4: ReplaceZlib: not a zlib stream
@pgaskin I've been meaning to say this for a while. The above patch really doesn't need to use BaseAddress. It's currently patching both GenericHomeWidget.qss and SubcategoryCarouselWidget.qss when only the former is necessary.
You could change the BaseAddress to FindZlib: "#homeWidgetTopContainer" to make it multi-version. Unless you know something about user demand for patching SubcategoryCarouselWidget.qss that I don't.
pgaskin
commented
3 years ago pgaskin
commented
3 years ago when only the former is necessary
Yes, that's correct.
You could change the BaseAddress to FindZlib: "#homeWidgetTopContainer" to make it multi-version
Hmm. I generally prefer to use find strings directly related to the patch in question, but I guess this quite close. I'll have to think about it.
Either way, this kind of thing won't be necessary anymore once I implement the qrc heuristics and integrate it into kobopatch.