Better Windows Service integration

pgaskin / pulseaudio-win32

An up-to-date PulseAudio build for Windows with an installer, service, socket support, bug fixes, and new features.

https://pgaskin.net/pulseaudio-win32

MIT License

73 stars 6 forks source link

Better Windows Service integration #2

Closed pgaskin closed 3 years ago

pgaskin commented 3 years ago

[x] Move service logic directly into pulseaudio/src/daemon/main.c.
[x] Decide whether to always attempt to create a service, or whether to put it behind a flag.
[x] Maybe make PulseAudio see the system service as a system instance rather than a user instance. This would also eliminate the need for messing with config paths when creating the service.
- [x] Figure out the implications of PA's system flag.
[x] Decide whether to keep the pasvc command.
[ ] Upstream the patch?

pgaskin commented 3 years ago

I found a bug in PulseAudio's pa_set_env while working on this (the env vars used for system mode weren't taking effect): it should use putenv (or putenv_s) rather than SetEnvironmentVariable on win32 so getenv can read the changed values.

Also see https://github.com/curl/curl/issues/4774.

pgaskin commented 3 years ago

Done in 27bfdd0bace421022ab95da52c5b7ac0bdb94ced.