search

pgaval / red5phone

Automatically exported from code.google.com/p/red5phone
0 stars 0 forks source link

An issue in populating o= field in SDP when username is blank. #156

Open GoogleCodeExporter opened 9 years ago

GoogleCodeExporter commented 9 years ago 
What steps will reproduce the problem?
1. In the flex version of red5phone login window, leave the value of username 
field to blank. 
2. Turn off the authentication challenge in SIP server 

What is the expected output? What do you see instead?
The o= field in SDP should be in the following format based on RFC2327
o=<username> <session id> <version> <network type> <address type> <address>
While, the o= field in SDP from the red5phone is:-
o= 0 0 IN IP4 127.0.1.1
Although, don't find in RFC2327 to state whether a text with 0 length is a 
valid username or not. Just looks weird. 

What version of the product are you using? On what operating system?
sip_r53.

Please provide any additional information below.
In SessionDescriptor.java#SessionDescriptor#127, if the owner is null, it will 
be set to "user@"+address. It will not cover the case owner="".
So the condition may be changed to if((owner==null) || (owner.length()==0))

Original issue reported on code.google.com by zhangjun...@gmail.com on 11 Jun 2011 at 3:21

GoogleCodeExporter commented 9 years ago 
Excellent contribution. Many thanks. I will update code.

Original comment by olajide....@gmail.com on 12 Jun 2011 at 2:50