Closed GoogleCodeExporter closed 9 years ago
Borja,
thanks for submitting this patch. I've just got a chance to basically review
it. The suggested modifications are reasonable and mostly acceptable, but I'll
need some more time to better analyze all the changes and apply them. So, I'll
do that after the holidays.
Regards,
Arsen
Original comment by achalo...@gmail.com
on 30 Dec 2010 at 3:04
Hi Arsen,
Here the last version with some modifications (null pointer tests to avoid
coredumps...).
Regards,
Borja
Original comment by bsi...@gmail.com
on 7 Jan 2011 at 7:30
Attachments:
Hi Borja,
I divided, split the submitted patch into the logical parts and applied them
one by one making a few modifications in the code, trying to enhance the
functionality. Please see the comments and diffs of the following commits and
let me know if I missed anything.
http://code.google.com/p/unimrcp/source/detail?r=1795
http://code.google.com/p/unimrcp/source/detail?r=1796
http://code.google.com/p/unimrcp/source/detail?r=1797
I also added you to the contributors list
http://code.google.com/p/unimrcp/source/detail?r=1798
Thnaks,
Arsen
Original comment by achalo...@gmail.com
on 2 Feb 2011 at 8:22
Original issue reported on code.google.com by
bsi...@gmail.com
on 15 Nov 2010 at 7:48Attachments: