search

pgbross / vue-material-adapter

Vue wrapper arround Material Components for the Web
ISC License
105 stars 20 forks source link

fix: setting menu-surface position #188

Closed axxie closed 3 years ago

axxie commented 3 years ago

The issue is that setting style property to "undefined" doesn't reset the current value. Because of that, depending on the current position of the menu, it is positioned using both "top" and "bottom" properties. The result is that menu changes its size instead of just being positioned.

Fixed by setting to empty string.

axxie commented 3 years ago

@pgbross, this one didn't go to the v4.0.2.. I thought both 3.x and 4.x are in active development. If only 4.x is being developed, this commit should be merged there instead of main.

pgbross commented 3 years ago

I will back port it to 3.x.

4.x is really what I had wanted to be the current deployment, but the new List stuff is not quite ready in the underlying material-components-web so I left it tagged 'next' so people would be careful to see if it was ok for their use.

axxie commented 3 years ago

I see. My idea was that menu position is annoying and should be fixed in both versions, so I added it to 3.x expecting it will also somehow land in 4.x I care less about non functional menu hoisting to body, so I thought it could be only added to the 4.x. Now I see that bug fixes probably should go to 3.x first. Is that right?