Open workingjubilee opened 10 months ago
This code shared between cargo-pgrx and pgrx-tests needs
that seems like an incomplete thought, but...
I wonder if cargo-pgrx
could benefit from a "createdb" command (probably "dropdb" too), then pgrx-tests
could just shell out to PGPORT=xxxx PGDATA=xxxx cargo pgrx createdb ${test_db_name}
.
I don't really see any particular harm in that since cargo-pgrx
is a required build tool.
pgrx-pg-config is better off being solely responsible for interacting with the
pg_config
binary, but it contains logic used in two other places, that doesn't really have anything to do with interacting withpg_config
, likecreatedb
(used in cargo-pgrx and pgrx-tests).This has a few problems:
createdb
specifically, it does apply to the code invoking createdb...