search

pgcentralfoundation / pgrx

Build Postgres Extensions with Rust!
Other
3.42k stars 223 forks source link

Fix lifetimes for IO functions #1733

Closed workingjubilee closed 4 weeks ago

workingjubilee commented 4 weeks ago

While sorting out lifetime problems to make #1731 landable, I noticed JsonInOutFuncs is completely replaceable with two reexports. So I replaced it. This also made the changes to sort out the rest of the lifetimes obvious, and now we return CString always from these functions.

workingjubilee commented 4 weeks ago

This plus another small fix reduces the error output remaining for #1731 from 465 to 305 lines.

workingjubilee commented 4 weeks ago

235, actually.

workingjubilee commented 4 weeks ago

Another fix and now down to 199, and now I just need to rethink how I'm doing the ArgAbi impl for Vec.