search

pgcentralfoundation / pgrx

Build Postgres Extensions with Rust!
Other
3.42k stars 223 forks source link

Add CI clippy test to auto-generated code #1741

Closed nyurik closed 6 days ago

nyurik commented 1 week ago

User code with these enabled causes clippy warnings. Please add an integration test as part of CI to ensure generated code does not trigger any warnings, e.g. cargo clippy --workspace --all-targets --bins --tests --lib --benches --examples -- -D warnings and RUSTDOCFLAGS="-D warnings" cargo doc --no-deps

#![warn(unused_qualifications)]
#![warn(clippy::pedantic)]

See also #1740

workingjubilee commented 1 week ago

Clippy not recognizing code is macro-generated is a clippy bug.

workingjubilee commented 6 days ago

I will not do what you ask.

I will do https://github.com/pgcentralfoundation/pgrx/pull/1744

I hope it suffices.