search

pgchange / jquery-star-rating-plugin

Automatically exported from code.google.com/p/jquery-star-rating-plugin
0 stars 0 forks source link

Patch for /trunk/jquery.rating.js #132

Open GoogleCodeExporter opened 8 years ago

GoogleCodeExporter commented 8 years ago 
After this simple fix, it becomes possible to set options via data-* like this, 
without the need for the jquery.metadata plugin:

<input class="star" data-split="4" ...

It looks like this was meant to work, but the code accidentally checks $.meta 
instead of $.data. I don't think checking $.meta makes any sort of sense, so it 
was probably meant to be $.data all along.

Original issue reported on code.google.com by igo...@gmail.com on 9 May 2013 at 5:34

Attachments:

GoogleCodeExporter commented 8 years ago 
One additional comment about my patch... I only tested that when the 
jquery.metadata plugin is absent, you can set the options via data-*. When 
jquery.metadata is loaded, I don't know whether it will check the data-* 
attributes.

It would probably be nicer to fix this issue in a way such that the data-* 
attributes work regardless of whether jquery.metadata is loaded. For my 
purposes, the fix in the patch is sufficient because I want to use quarter 
stars without loading jquery.metadata.

Original comment by igo...@gmail.com on 9 May 2013 at 5:58

GoogleCodeExporter commented 8 years ago 
Oh, I just created a kind of duplicate for this one

http://code.google.com/p/jquery-star-rating-plugin/issues/detail?id=139

Original comment by rdeho...@gmail.com on 27 Sep 2013 at 11:24