search

pgeu / pgeu-system

Mirror of the PostgreSQL Europe Conference and Membership management system.
MIT License
20 stars 28 forks source link

Avoid using h5 in dt context for eventlist #120

Open danielgustafsson opened 1 year ago

danielgustafsson commented 1 year ago

The h5 element is not allowed as a descendant of a dt element as dl is defined as flow content whereas hX is phrasing content. Fix by replacing with a span and CSS to match the styling that the h5 element provided.

Also fix three-space indentation while in there.

mhagander commented 1 year ago

This doesn't look right to me. You're creating a <span class="eventtitle">, but the CSS update is for dt.eventtitle. Can and should we not just skip the span and assign class="eventtitle" directly to the dt element?

danielgustafsson commented 1 year ago

Agreed, I've pushed a rebased version doing this which seems a better option.