fix: use luatexbase to register pgfsys@strcmp

pgf-tikz / pgf

A Portable Graphic Format for TeX

https://pgf-tikz.github.io/

1.15k stars 108 forks source link

fix: use luatexbase to register pgfsys@strcmp #1364

Open hmenke opened 1 month ago

hmenke commented 1 month ago

Motivation for this change

Workaround for https://github.com/latex3/latex2e/issues/1100

Checklist

Please signoff your commits to explicitly state your agreement to the Developer Certificate of Origin. If that is not possible you may check the boxes below instead:

[x] Code changes are licensed under GPLv2 + LPPLv1.3c
[x] Documentation changes are licensed under FDLv1.2

muzimuzhi commented 1 month ago

The logic looks OK to me, but overall my LuaTeX knowledge is not enough to review this PR.

As for l3kernel, it defines \tex_strcmp:D for LuaTeX using its own wrapper luacmd(name, func, ...), see here. Checking how luacmd() is defined, it loads ltluatex module if none of context and luatexbase are loaded and has a special branch if context module is loaded.

Linking to #1362 and don't forget to add a Changelog entry.