search

pgfoster / p4-phylogenetics

A Python phyloinformatic toolkit, and an implementation of tree-heterogeneous models of evolution
GNU General Public License v2.0
29 stars 8 forks source link

Matrix recoding modules #3

Closed blaiseli closed 7 years ago

blaiseli commented 8 years ago

Hi Peter,

I tried to integrate updated versions of the matrix recoding modules that we used in Cox et al 2014 and Li et al. 2014. I didn't include the script that uses them, though. Do you think it may fit in P4 ?

pgfoster commented 7 years ago

Hi Blaise,

Thanks for the new code. It looks good, although there may be some repetition eg of genetic code definitions -- is that so?

There are two good places for the script that you mentioned. There is the share/Examples directory, and it would be great to have a working example there. The other place is in the Misc directory, which might also be a good place for the script. I suppose the Examples directory would be best because it would be more complete.

Another possibility, which might help it being noticed, is to have a tutorial page in the docs for it. -Peter