search

pgh-public-meetings / city-scrapers-pitt

Pittsburgh City Scrapers: sourcing public meetings in Pittsburgh
https://pgh-public-meetings.github.io/events/
MIT License
19 stars 66 forks source link

Use Black for Consistent Formatting and Deprecate isort/yapf/flake8 #145

Closed ben-nathanson closed 3 years ago

ben-nathanson commented 3 years ago

This implements Black as our one-stop linter and removes isort/yapf/flake8. These are all great linting tools for different use cases but using Black here will help new contributors focus on writing code rather than formatting code.

ben-nathanson commented 3 years ago

The scraping step of our CI run timed out because the Allegheny County Authority for Improvements in Municipalities (AIM) website is not responding. The base domain has changed from county.allegheny.pa.us to alleghenycounty.us. Even after fixing the URL, it looks like the spider is failing to grab any events and could use a refactor. I have created a separate ticket #146 to address the timeout problem which was unrelated to this PR.

I believe it should be safe to merge #145 once we fix the boto3 dependency issue. Once #145 is merged we will want to reach out to anyone with works in progress so that they can transition to black.