pgh-public-meetings / city-scrapers-pitt

Pittsburgh City Scrapers: sourcing public meetings in Pittsburgh
https://pgh-public-meetings.github.io/events/
MIT License
19 stars 66 forks source link

The latest isort module doesn't work in CI #160

Closed will-snavely closed 3 years ago

will-snavely commented 3 years ago

See this failed run: https://github.com/pgh-public-meetings/city-scrapers-pitt/pull/159/checks?check_run_id=1021603379

Run pipenv run isort --check-only --diff || exit 1

Error: arguments passed in without any paths or content.

                 _                 _
                (_) ___  ___  _ __| |_
                | |/ _/ / _ \/ '__  _/
                | |\__ \/\_\/| |  | |_
                |_|\___/\___/\_/   \_/

      isort your imports, so you don't have to.

                    VERSION 5.4.2

Nothing to do: no files or paths have have been passed in!

Try one of the following:

    `isort .` - sort all Python files, starting from the current directory, recursively.
    `isort . --interactive` - Do the same, but ask before making any changes.
    `isort . --check --diff` - Check to see if imports are correctly sorted within this project.
    `isort --help` - In-depth information about isort's available command-line options.

Visit https://timothycrosley.github.io/isort/ for complete information about how to use isort.

##[error]Process completed with exit code 1.

I think this is because the latest version of isort might have changed the command line interface? I'm not totally sure, will require a little bit of investigation. Some options include:

will-snavely commented 3 years ago

This seems to be fixed now, see this run from the merged pull request: https://github.com/pgh-public-meetings/city-scrapers-pitt/actions/runs/240203372/workflow

will-snavely commented 3 years ago

I can't figure out how to link issues to PR's, but this was addressed, for now, by: https://github.com/pgh-public-meetings/city-scrapers-pitt/pull/162