search

pgh-public-meetings / city-scrapers-pitt

Pittsburgh City Scrapers: sourcing public meetings in Pittsburgh
https://pgh-public-meetings.github.io/events/
MIT License
19 stars 66 forks source link

City Scrapers Calendar is not Rendering Events #177

Closed ben-nathanson closed 3 years ago

ben-nathanson commented 3 years ago

Today I found that our calendar is not showing any events.

We know that we are getting the list of upcoming events from our S3 bucket, but those events are not being rendered on the calendar. This would point to an unexpected input when the list is getting parsed, or some exception before the parsing step that is diverting the website from parsing in the first place. There is at least one type error in the console along with a reference to cityscrapers.org/agency, which is no longer a valid URL. This is unlikely to be the source of the problem as the parent project at City-Bureau logs the same error, but works nonetheless.

This brings the more long-term question of not having an automated test to check that at least one event shows up on the calendar. I could probably work on this but I want to fix the immediate bug first.

ben-nathanson commented 3 years ago

This bug has been reproduced across Chrome/Safari/Firefox.

ben-nathanson commented 3 years ago

I forked and cloned a copy of the events repo to my local machine. When I run npm start I get the same behavior (no events, spinny wheel of death).

I think this might just be a bug in the events repo and not city-scrapers-pitt, since the data in upcoming.json looks fine. If that turns out to be the case I will close this issue and move tracking over to the events repo.

Going to test what happens when we swap in Chicago's data for Pittsburgh. If that works, then the problem is more likely in the data.

ben-nathanson commented 3 years ago

By cloning the Chicago repo and injecting our events we get this: image

So this does appear to be a front-end issue.