search

pgh-public-meetings / city-scrapers-pitt

Pittsburgh City Scrapers: sourcing public meetings in Pittsburgh
https://pgh-public-meetings.github.io/events/
MIT License
19 stars 66 forks source link

[Sentry] [pa_liquorboard] local variable referenced before assignment #178

Closed bonfirefan closed 3 years ago

bonfirefan commented 3 years ago

Error: [pa_liquorboard] UnboundLocalError("local variable 'found_start_hour' referenced before assignment") Check if website / website format is constant

TylerDunlap commented 3 years ago

Hello, I'm a new contributor. looking at the website and an archived copy it looks like the start time was removed:

current: current

previous: previous

ben-nathanson commented 3 years ago

This is the kind of change we wanted to catch when we refactored pa_liquorboard a few months ago. Although if I were doing it again I would have thrown a more explicit exception.

What's even more interesting is that the changes to the website make it such that the start time does not appear anywhere except for the minutes. I think our only option from here would be to assume a start time of 11:00 AM (which I'm not crazy about since it potentially brings down the accuracy/flexibility of the calendar) and call this out in the time_notes field.

ben-nathanson commented 3 years ago

Also, @TylerDunlap, we're glad to have you! Feel free to ping me if you have any questions as far as getting started.