search

pgh-public-meetings / city-scrapers-pitt

Pittsburgh City Scrapers: sourcing public meetings in Pittsburgh
https://pgh-public-meetings.github.io/events/
MIT License
19 stars 66 forks source link

Add pa_development spider, test, and test files #38

Closed ben-nathanson closed 4 years ago

ben-nathanson commented 5 years ago

Closes issue #23.

I received two deprecation warnings from pytest, but I believe this has more to do with Scrapy than this particular spider. Let me know if there are any improvements I can make.

Thanks! --Ben

bonfirefan commented 5 years ago

Hey @ben-nathanson, we've made some updates so that the build will pass - if you can merge in changes from upstream/master and commit those changes, I think we'll be good to go

ben-nathanson commented 5 years ago

Note: I'm working on a minor timezone bug. Once that's all cleared up, I will follow up here. At that point, feel free to merge this! -- Ben

danwarren commented 5 years ago

is this pull deprecated? it looks like this scraper is in master, and a simple pull of the 0023 branch deletes needed test files.

ben-nathanson commented 5 years ago

Once @ #61 is merged, pa_development should pass Travis CI checks and be ready to merge.