search

pgh-public-meetings / city-scrapers-pitt

Pittsburgh City Scrapers: sourcing public meetings in Pittsburgh
https://pgh-public-meetings.github.io/events/
MIT License
19 stars 66 forks source link

[WIP] Spider pa liquorboard #41

Closed lyons7 closed 5 years ago

bonfirefan commented 5 years ago

Hey @lyons7, great work! We made an update because our testing environment got unhappy - if you can merge in changes from upstream/master that would be great.

bonfirefan commented 5 years ago

This pull request addresses Issue #24 (Kate, something I forgot to mention - when you make a pull request, if you tag the original Issue number, it will close the issue when closing the pull request!)

lyons7 commented 5 years ago

Hi Bonnie! I would very happily do this, but I am not sure how! Is this something I do in Github or via the command line? Sorry! i've been googling this all week and can't figure it out what exactly I need to do. Thanks for your help, I appreciate it!

Kate

On Sat, Apr 13, 2019 at 11:26 AM bonfirefan notifications@github.com wrote:

Hey @lyons7 https://github.com/lyons7, great work! We made an update because our testing environment got unhappy - if you can merge in changes from upstream/master that would be great.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/bonfirefan/city-scrapers-pitt/pull/41#issuecomment-482821532, or mute the thread https://github.com/notifications/unsubscribe-auth/AQJRU7N2s0By8YDiDfIO9kbUR9vd6v7dks5vgfc2gaJpZM4cTcNR .

ben-nathanson commented 5 years ago

To close an issue via the command line, add the phrase Closes: #[issue number] to the commit message. For example if I had an issue number 1 that I wanted to close, I would do git commit -m "Closes: #1". Let me know if that helps!