0008 spider pitt zoning #2

pgh-public-meetings / city-scrapers-pitt

Pittsburgh City Scrapers: sourcing public meetings in Pittsburgh

https://pgh-public-meetings.github.io/events/

MIT License

19 stars 66 forks source link

0008 spider pitt zoning #2 #46

Closed danwarren closed 3 years ago

danwarren commented 5 years ago

I re-based my fork, previous manual merges with master had rendered it unable to pass CI

bonfirefan commented 5 years ago

Hey @danwarren thanks for the fixes you're making here. @pjsier just made some changes so that Travis installs from requirements.txt and that seems to be working

dkori commented 4 years ago

Tests pasts locally on my machine

bonfirefan commented 4 years ago

A reminder to sync this with the upstream fork so that Travis tests will past! Also, to enable edits from maintainers!

Enable edits from maintainers!:

In the the right sidebar of your pull request, select Allow edits from maintainers. You can change these permissions at any time by unselecting this option.

Syncing your fork:

git remote add upstream https://github.com/bonfirefan/city-scrapers-pitt.git
git fetch upstream
git merge upstream/master

bonfirefan commented 3 years ago

Hey Dan - try syncing your updates to latest and delete the travis file. You'll have some pipfile and pipfile lock conflicts -

keep both the pytz package and your new pydf2 package
keep w3lib form head in pipfile lock
delete travis.yml file

After that it looks like there are some yapf errors - check them with pipenv run yapf --diff --recursive ./city_scrapers/ ./tests/

ben-nathanson commented 3 years ago

Closing as this has been inactive for some time. Happy to revisit when changes are made!