@bonfirefan opening this up to start the conversation on a few things. This includes some cleaup and updates that have been useful in the other repos:
Simplifies the requirements.txt file to what's included in the Pipfile, since the versions don't need to be as specific as they currently are
Updates city-scrapers-core and includes the aws extra since you're deploying to S3
Removes the unused MigrationPipeline
Specifies SENTRY_DSN in the production settings. As long as SENTRY_DSN is set as a Travis CI secret environment variable that should work
Renames CityPlanning to PittCityPlanning so that it uses the location prefix
I also wanted to make a few other notes on changes I didn't make here but are worth considering. I can open up issues for any of them, but wanted to just mention them first here:
It looks like some of the template details are still in the README, CODE_OF_CONDUCT, and LICENSE so those would be good to update
We moved away from the JSCalendar pipeline to using the standard Open Civic Data format, and the only change it takes is switching the pipeline you're using. From talking to some folks who are using OCD, it feels like a worthwhile standard to try and use over the JSCalendar setup which we were trying out. Up to you though
We made some updates on the main calendar repo that I could put in a PR for as well
Moving this repo into the city-scrapers-pitt organization might make managing things a bit easier. GitHub automatically redirects all requests from any repo where you transfer ownership, so it shouldn't cause too much confusion
@bonfirefan opening this up to start the conversation on a few things. This includes some cleaup and updates that have been useful in the other repos:
requirements.txt
file to what's included in thePipfile
, since the versions don't need to be as specific as they currently arecity-scrapers-core
and includes theaws
extra since you're deploying to S3MigrationPipeline
SENTRY_DSN
in the production settings. As long asSENTRY_DSN
is set as a Travis CI secret environment variable that should workCityPlanning
toPittCityPlanning
so that it uses the location prefixI also wanted to make a few other notes on changes I didn't make here but are worth considering. I can open up issues for any of them, but wanted to just mention them first here: