pgh-public-meetings / city-scrapers-pitt

Pittsburgh City Scrapers: sourcing public meetings in Pittsburgh
https://pgh-public-meetings.github.io/events/
MIT License
19 stars 66 forks source link

Pytest Failing on Fresh Clone #77

Closed KavanMally closed 4 years ago

KavanMally commented 4 years ago

I am trying to run pytest on a fresh clone of the main repo. Following instructions from the main documentation, I cloned a new copy of the repository, created a pipenv, synced it, and ran a sample spider. Running 'pytest' in bash will give the following traceback.

Traceback (most recent call last): File "/home/kavan/.local/share/virtualenvs/city-scrapers-pitt-vm2XhXX5/bin/pytest", line 5, in <module> from pytest import main File "/home/kavan/.local/share/virtualenvs/city-scrapers-pitt-vm2XhXX5/lib/python3.5/site-packages/pytest/__init__.py", line 6, in <module> from _pytest.assertion import register_assert_rewrite File "/home/kavan/.local/share/virtualenvs/city-scrapers-pitt-vm2XhXX5/lib/python3.5/site-packages/_pytest/assertion/__init__.py", line 7, in <module> from _pytest.assertion import rewrite File "/home/kavan/.local/share/virtualenvs/city-scrapers-pitt-vm2XhXX5/lib/python3.5/site-packages/_pytest/assertion/rewrite.py", line 29, in <module> from _pytest.pathlib import fnmatch_ex File "/home/kavan/.local/share/virtualenvs/city-scrapers-pitt-vm2XhXX5/lib/python3.5/site-packages/_pytest/pathlib.py", line 26, in <module> from pathlib2 import Path, PurePath ImportError: No module named 'pathlib2'

Specs: Linux Mint 18.3 (Virtual Machine) Python: 3.5.2 Pip (pipenv): 19.3.1

ben-nathanson commented 4 years ago

Hey @KavanMally -- just wanted to touch base and see if you made any progress with this bug or had a chance to recreate it on another machine. Thank you for posting this bug!

I'm sorry to say I haven't been able to find much on this specific error + OS combination but I will add this into our documentation. The dependencies for this project should run on Linux, especially a common distro like Linux Mint, but I have seen many issues like this.

Thanks, --Ben

bonfirefan commented 4 years ago

Hey @KavanMally - your issue should be resolved with the merge for #81 We added a requirement for pathlib, which is needed for python 3.5 in the pipfile: pathlib2 = {version = "*",python_version = "< '3.6'"} Make sure to sync your fork and run pipenv install again - hopefully that should fix the issue!